• Adam Klein's avatar
    [ast] Save one pointer in most Function and Variable declaration node · 69b165db
    Adam Klein authored
    Currently, Declaration stores a Scope pointer to whichever Scope the
    declaration appeared in. This is used to disallow var declarations
    being hoisted over lexical declarations. For example:
    
      {
        let x;
        { var x; }
      }
    
    But in fact this is the only sort of case where storing the scope
    is required: for lexical declarations (including function declarations
    appearing in blocks), Declaration::scope() was always identical to
    Declaration::proxy()->var()->scope(). That is, only var declarations
    end up "nested" in this way.
    
    This patch adds a subclass of VariableDeclaration to store the Scope.
    Since the only thing that cares about that data is Scope analysis,
    this isn't treated as a distinct AstNode::NodeType from VariableDeclaration,
    leaving all AstVisitors untouched in the process.
    
    Also reworked the logic in Scope::CheckConflictingVarDeclarations() for
    clarity after making changes to accomodate the new code.
    
    Change-Id: I6ee4298700508ab9e28a76ddb8504bae68bc473f
    Reviewed-on: https://chromium-review.googlesource.com/619595
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47441}
    69b165db
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...