• Benedikt Meurer's avatar
    [turbofan] Optimize index checking for DataView accesses. · 69985ac5
    Benedikt Meurer authored
    Use CheckBounds and reduce the number of checks required to sanitize the
    indices for DataView accesses in optimized code. Also constant-fold the
    [[ByteLength]] if the DataView is a known compile-time constant (similar
    to what we do for TypedArrays already). This further improves performance
    of DataViews by 2-7% depending on the exact test case.
    
    With this change DataView and TypedArray accesses themselves are mostly
    on par performance wise.
    
    Since this CL introduces proper CheckBounds for the DataViews, instead
    of the hand-craftet bounds checks, it is expected to regress performance
    when untrusted code mitigations are on, since DataViews are also guarded
    in optimized now. Without untrusted code mitigations, there's no negative
    performance impact.
    
    Tbr: sigurds@chromium.org
    Bug: chromium:225811, chromium:876005
    Change-Id: I4a69f81124635c9ba2c7e4c2dc912e2fd601061a
    Reviewed-on: https://chromium-review.googlesource.com/1186408Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55346}
    69985ac5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...