• Clemens Hammacher's avatar
    [wasm] Store WasmEngine in NativeModule · 69546692
    Clemens Hammacher authored
    The {CompilationState} currently stores the {WasmEngine}, while the
    {NativeModule} only stores the {WasmCodeManager}. From a high-level
    view, this does not make much sense. The {NativeModule} belongs to
    exactly one {WasmEngine}, so that link should be stored there. We can
    then get to the {WasmCodeManager} from the {WasmEngine}.
    
    This change requires a refactoring of the {WasmCodeManagerTest} which
    created {WasmCodeManager}s independent of the {Isolate} and the
    {WasmEngine}. This is not supported any more.
    Note that in production, each {WasmEngine} owns exactly one
    {WasmCodeManager} and one {WasmMemoryTracker}, so testing that a
    {WasmMemoryTracker} can be shared by several {WasmCodeManager}s didn't
    make sense in the first place.
    
    R=mstarzinger@chromium.org
    
    Bug: v8:8217
    Change-Id: I582e698be35f97dbd38bf6e12eb7f8ee4fc1f0f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1297960
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56992}
    69546692
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...