• hablich's avatar
    Revert of [wasm] instantiate expressed in terms of compile (patchset #6... · d3f1d5c5
    hablich authored
    Revert of [wasm] instantiate expressed in terms of compile (patchset #6 id:140001 of https://codereview.chromium.org/2806073002/ )
    
    Reason for revert:
    Roll blocker: https://bugs.chromium.org/p/chromium/issues/detail?id=710824
    
    Original issue's description:
    > [wasm] instantiate expressed in terms of compile
    >
    > Today, the semantics of:
    >
    > WebAssembly.instantiate
    >
    > and
    >
    > WebAssembly.compile().then(new WebAssemblyInstance)
    >
    > are subtly different, to the point where attempting the proposed
    > change uncovered bugs.
    >
    > In the future, it's possible that .instantiate actually have different
    > semantics - if we pre-specialized to the provided ffi, for example.
    > Right now that's not the case.
    >
    > This CL:
    > - gets our implementation closer to what developers may write using
    > the compile -> new Instance alternative, in particular wrt promise
    > creation. By reusing code paths, we uncover more bugs, and keep
    > maintenance cost lower.
    >
    > - it gives us the response-based WebAssembly.instantiate implicitly.
    > Otherwise, we'd need that same implementation on the blink side. The
    > negative is maintenance: imagine if the bugs I mentioned could only be
    > found when running in Blink.
    >
    > BUG=chromium:697028
    >
    > Review-Url: https://codereview.chromium.org/2806073002
    > Cr-Commit-Position: refs/heads/master@{#44592}
    > Committed: https://chromium.googlesource.com/v8/v8/+/7829af3275ff4644a2d0a1270abe1a1e4415e9fb
    
    TBR=bradnelson@chromium.org,ahaas@chromium.org,adamk@chromium.org,mtrofin@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:697028
    
    Review-Url: https://codereview.chromium.org/2810203002
    Cr-Commit-Position: refs/heads/master@{#44614}
    d3f1d5c5
Name
Last commit
Last update
..
embenchen Loading commit data...
OWNERS Loading commit data...
adapter-frame.js Loading commit data...
add-getters.js Loading commit data...
asm-wasm-copy.js Loading commit data...
asm-wasm-deopt.js Loading commit data...
asm-wasm-exception-in-tonumber.js Loading commit data...
asm-wasm-expr.js Loading commit data...
asm-wasm-f32.js Loading commit data...
asm-wasm-f64.js Loading commit data...
asm-wasm-heap.js Loading commit data...
asm-wasm-i32.js Loading commit data...
asm-wasm-literals.js Loading commit data...
asm-wasm-names.js Loading commit data...
asm-wasm-stack.js Loading commit data...
asm-wasm-stdlib.js Loading commit data...
asm-wasm-switch.js Loading commit data...
asm-wasm-u32.js Loading commit data...
asm-wasm.js Loading commit data...
asm-with-wasm-off.js Loading commit data...
async-compile.js Loading commit data...
calls.js Loading commit data...
compilation-limits-asm.js Loading commit data...
compilation-limits.js Loading commit data...
compiled-module-management.js Loading commit data...
compiled-module-serialization.js Loading commit data...
data-segments.js Loading commit data...
divrem-trap.js Loading commit data...
ensure-wasm-binaries-up-to-date.js Loading commit data...
errors.js Loading commit data...
exceptions.js Loading commit data...
export-table.js Loading commit data...
ffi-error.js Loading commit data...
ffi.js Loading commit data...
float-constant-folding.js Loading commit data...
function-names.js Loading commit data...
function-prototype.js Loading commit data...
gc-buffer.js Loading commit data...
gc-frame.js Loading commit data...
gc-stress.js Loading commit data...
globals.js Loading commit data...
grow-memory.js Loading commit data...
import-memory.js Loading commit data...
import-table.js Loading commit data...
incrementer.wasm Loading commit data...
indirect-calls.js Loading commit data...
indirect-tables.js Loading commit data...
instance-gc.js Loading commit data...
instance-memory-gc-stress.js Loading commit data...
instantiate-module-basic.js Loading commit data...
instantiate-run-basic.js Loading commit data...
interpreter-mixed.js Loading commit data...
interpreter.js Loading commit data...
js-api.js Loading commit data...
jsapi-harness.js Loading commit data...
memory-instance-validation.js Loading commit data...
memory-size.js Loading commit data...
memory.js Loading commit data...
module-memory.js Loading commit data...
names.js Loading commit data...
parallel_compilation.js Loading commit data...
params.js Loading commit data...
receiver.js Loading commit data...
stack.js Loading commit data...
stackwalk.js Loading commit data...
start-function.js Loading commit data...
table.js Loading commit data...
test-import-export-wrapper.js Loading commit data...
test-wasm-module-builder.js Loading commit data...
trap-location.js Loading commit data...
unicode-validation.js Loading commit data...
unreachable-validation.js Loading commit data...
unreachable.js Loading commit data...
verify-module-basic-errors.js Loading commit data...
wasm-constants.js Loading commit data...
wasm-default.js Loading commit data...
wasm-module-builder.js Loading commit data...
wasm-object-api.js Loading commit data...