• Andreas Haas's avatar
    [turbofan] For Word32Shl optimizations only consider the last 5 bits of the shift · 5f1661aa
    Andreas Haas authored
    One optimization in the machine-operator-reducer did not consider that
    that word32 shift left instructions only consider the last 5 bits of
    the shift input.
    
    The issue only occurs for WebAssembly because in JavaScript we always
    add a "& 0xf" on the shift value to the TurboFan graph.
    
    For additional background: The JavaScript and WebAssembly spec both
    say that only the last 5 bits of the shift value are used in the
    word32-shift-left operation. This means that an "x << 0x29", in the
    code is actually executed as "x << 0x09". Therefore the changes in
    this CL are okay because they mask the last 5 bit of the shift value.
    
    BUG=chromium:689450
    
    Change-Id: Id92f298ed6d7f1714b109b3f4fbcecd5ac6d30f7
    Reviewed-on: https://chromium-review.googlesource.com/439312Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43245}
    5f1661aa
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...