• Seth Brenith's avatar
    [torque] Get rid of `weak` keyword · 6745405f
    Seth Brenith authored
    Torque allows a `weak` keyword on class field declarations. This keyword
    is confusing, because it means two completely different things:
    
    1. This field should be included in the weak fields section, meaning the
       field's offset should be in the range [kStartOfWeakFieldsOffset,
       kEndOfWeakFieldsOffset).
    2. If a BodyDescriptor is generated for this class, then this field
       should be visited using *custom* weakness semantics
       (IterateCustomWeakPointers, not IterateMaybeObjectPointers).
    
    I propose the following updated behavior, which I think is a bit more
    reasonable:
    
    1. To request that the generated BodyDescriptor use custom weakness
       semantics, use a new annotation @customWeakMarking.
    2. The weak fields section includes all fields that can be a Weak<T>
       type, plus those annotated with @customWeakMarking.
    
    These new rules require reordering fields in two classes which didn't
    already have all of their strong fields adjacent.
    
    Bug: v8:7793
    Change-Id: Ic9d741986afa7fc1be3de044af5cae11a3c64d8c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3261968
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77739}
    6745405f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...