• Ng Zhi An's avatar
    [compiler] Load ops should not increase effect level · 66cbbb7a
    Ng Zhi An authored
    The idea of effect level was introduced in
    https://codereview.chromium.org/1706763002. This change was trying to
    optimize sequences like:
    
      x = load o, i
      cmp 1, x
    
    to use a memory operand:
    
      cmp 1, [o+i]
    
    However, the load can be invalidated, like so:
    
      x = load o, i
      store o, i, v
      cmp 1, x
    
    Then, selecting a memory operand for cmp would be incorrect (it should
    be using the loaded value x, not the store valued v:
    
      store o, i, v
      cmp 1, [o+i]  # uses v, which is wrong, should use x
    
    Effect levels were introduced to mark where levels of potentially
    invalidating instructions:
    
                      effect level
      x = load o, i      0
      store o, i, v      1
      cmp 1, x           1
    
    Then when selecting instructions, CanCover will check to ensure that cmp
    and load are on the same level.
    
    ProtectedLoad, and LoadTransforms should not affect the effect levels in
    this case, because they don't invalidate any prior loads:
    
      x = load o, i
      y = protected load o, i
      cmp 1, x
    
    Becomes:
    
      y = protected load o, i
      cmp 1, [o+i]
    
    Bug: v8:12189
    Change-Id: I585b94320def4ba554ae955fa5f8fcc9efd6dafe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158551Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76826}
    66cbbb7a
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...