• Dmitry Gozman's avatar
    [inspector] Prepend isolateId to remoteObjectId · 66725a53
    Dmitry Gozman authored
    This changes remoteObjectId format from
    "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>".
    
    Prepending isolateId fixes the problem that
    remote object ids clash between processes. This is especially
    troubling during cross-process navigation in Chromium, see bug.
    
    We also stop producing and parsing unnecessary json for object ids.
    
    Drive-by: fixed some tests dumping object ids. Most tests avoid
    dumping unstable values like ids, but there were few that still did.
    
    BUG=chromium:1137143
    
    Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70592}
    66725a53
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...