• Michael Lippautz's avatar
    Reland "[handles] Remove precise on-stack representation of global handles" · 65d43890
    Michael Lippautz authored
    This is a reland of commit 6953b555
    
    The reland fixes tests that retrieved the stack start from a
    non-inlined frame's fp. This does not work in certain configurations
    as the resulting marker is too low to consider the first local
    variables in subsequent calls.
    
    The fix uses an inline frame address for the tests to get an upper
    bound of stack addresses to consider.
    
    Original change's description:
    > [handles] Remove precise on-stack representation of global handles
    >
    > Since https://crrev.com/c/3806439 on-stack traced handles are marked
    > conservatively when being used in combination with CppHeap.
    >
    > This change removes the precise on-stack representation of the
    > internal traced nodes as they nodes would anyways be marked
    > conservatively. The effects are:
    > - cheaper representation (just a single node space);
    > - uniform handling: no checks to distinguish on-stack vs on-heap;
    > - no brittleness around cleaning on-stack handles when the event loop
    >  is empty;
    >
    > Change-Id: Id859623bfed77a66bdd064ea8065536264515eae
    > Bug: v8:13141
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812039
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82306}
    
    Bug: v8:13141
    Change-Id: I53ece36220e99d02be6df18f83c18450e5d5037b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820585Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82342}
    65d43890
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...