• Omer Katz's avatar
    cppgc: Handle low-address stack in write barrier. · 649d3c10
    Omer Katz authored
    Windows can allocate the stack at low addresses. A low-address on-stack
    slot (e.g. backing store reference for Blink's on-heap collections) with
    a null value would make TryGetCagedHeap falsely think that the slot
    resides in a caged heap that starts at a null address.
    
    We will still crash for low-address on-stack slots with non-null
    on-stack value, since these cases are not considered valid and should
    not happen.
    
    The null value check is added only to Windows. It is not an issue on
    other OSes where the stack always resides at high addresses and we
    prefer to keep the write barrier as cheap as possible.
    
    Bug: chromium:1230794, chromium:1056170
    Change-Id: I07e2d178cd95edba57015d6bc6eb127a443b0589
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069146
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76069}
    649d3c10
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...