• Michael Achenbach's avatar
    Revert "[interpreter] Move interrupt budget from BytecodeArray to FeedbackCell" · 64896325
    Michael Achenbach authored
    This reverts commit f3994485.
    
    Reason for revert:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26128
    
    Original change's description:
    > [interpreter] Move interrupt budget from BytecodeArray to FeedbackCell
    > 
    > Interrupt budget was store in bytecode array and used to be shared
    > across all contexts. With lazy feedback allocation, using context
    > independent interrupt budget might lead to performance cliffs when
    > we have closures that do not share the same feedback (for ex: across
    > contexts). This would be a problem even earlier but it could be
    > more pronounced with feedback vector allocation, since the budgets
    > for optimization is much higher (144x) than the budget for feedback
    > allocation.
    > 
    > Bug: chromium:948835, v8:8394
    > Change-Id: Ie3ac389e1c082d1671efd4d74abc076ce943301b
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558088
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60734}
    
    TBR=jarin@chromium.org,mlippautz@chromium.org,mythria@chromium.org,jgruber@chromium.org,bmeurer@chromium.org
    
    Change-Id: Icbec4d28d6ac258827e222461cff51f2a2f42472
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:948835, v8:8394
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560990Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60735}
    64896325
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...