• thakis's avatar
    Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode. · 643c24eb
    thakis authored
    Also, remove V8_CC_CLANG since it's not read anywhere (and ideally shouldn't
    be).
    
    Clang tries to be compatible with gcc in clang mode, and with msvc in clang-cl
    mode. It wants to go down the same code paths that these compilers want to go
    down in most cases.
    
    For example, V8PRIxPTR was set incorrectly on Windows 64-bit before this change
    since macros.h assumed that checking for V8_CC_MSVC is enough to find LLP64
    systems, but V8_CC_MSVC wasn't set for clang.  Most other existing checks for
    V8_CC_MSVC should be taken for clang-cl too (and for the remaining ones,
    clang-cl is happy with either code path).
    
    Likewise, V8_IMMEDIATE_CRASH is currently set to a suboptimal value with clang
    since __builtin_trap() is only used if V8_CC_GNU is set.
    
    Including clang in the gcc and cl macros is also what chromium does.
    
    BUG=chromium:82385
    LOG=y
    
    Review URL: https://codereview.chromium.org/757553004
    
    Cr-Commit-Position: refs/heads/master@{#25592}
    643c24eb
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...