• vogelheim's avatar
    Lolcode candidate: Both Expression and FunctionLiteral define an accessor... · 63f7fbfe
    vogelheim authored
    Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthesized(), which access different flags. FunctionLiteral derives from Expression.
    
    Given
          FunctionLiteral* a; a->is_parenthesized()
    const FunctionLiteral* b; b->is_parenthesized()
    
    the first accesses FunctionLiteral::IsParenthesized, the second accesses Expression::IsParenthesizedField.
    
    Since these are distinct uses, we could rename them based on their use:
    - Expression::is_parenthesized -> is_single_parenthesized
      Count # of parenthesis, for parsing & error handling:
      no parenthesis -> single parenthesis -> multi parenthesis
    - FunctionLiteral::eager_compile_hint()
      Hint from parser to compiler about whether the parser suggests this function for eager compilation.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1097723005
    
    Cr-Commit-Position: refs/heads/master@{#28042}
    63f7fbfe
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...