• Clemens Backes's avatar
    Reland "[elements] Avoid racy data reads/writes" · 63b7afb4
    Clemens Backes authored
    This is a reland of 296fa964. The fix is
    to dynamically check for alignment instead of relying on
    {alignof(ElementType)}. I updated the comment to state that independent
    of pointer compression we do not guarantee the alignment that the
    compiler assumes (hence we rely on undefined behaviour here).
    
    Original change's description:
    > [elements] Avoid racy data reads/writes
    >
    > Instead of annotating those racy reads / writes to be ignore by TSan,
    > just use relaxed atomics. This makes us not rely on undefined behaviour,
    > and is unlikely to introduce noticeable overhead.
    >
    > This removes the only uses of TSAN_ANNOTATE_IGNORE_WRITES_BEGIN and
    > friends, which allows us to remove the whole tsan.h header.
    >
    > R=ulan@chromium.org
    > CC=​mlippautz@chromium.org
    >
    > Bug: v8:11704
    > Change-Id: Ie6694c0ae5b40856b56fb97253ce626ec1f4c263
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859957
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74321}
    
    Bug: v8:11704
    Change-Id: If75674785ca776dac06ed821f0032f865793dd77
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_odroid_arm_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867479Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74402}
    63b7afb4
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...