• Georg Neis's avatar
    [compiler] Fix an issue with deprecated maps · 6288483b
    Georg Neis authored
    Various field dependencies assume that the receiver map and the field
    owner map agree on field meta data. That's not necessarily true when
    the receiver map is already deprecated. We should skip over deprecated
    maps.
    
    - Fix a bug in SerializerForBackgroundCompilation. It used to process
      even deprecated maps.
    - Fix a bug in FilterRelevantReceiverMaps. It used to store the original
      map rather than the new version.
    - Turn some compilation dependency DCHECKs into CHECKs.
    - CHECK in MapRef::FindFieldOwner that the map is not deprecated. While
      there might be valid use cases for calling the underlying
      Map::FindFieldOwner on a deprecated map, we never want to do that in
      the compiler.
    
    Note that we skip any deprecated maps in JSNativeContextSpecialization's
    ReduceNamedAccess. That's why I believe the issue could only be observed
    with --concurrent-inlining and only in the form of a failing DCHECK.
    
    Bug: chromium:1221812, v8:7790
    Change-Id: I998b4ce1954be01eb6e0feb491ccc6b8306c685f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976655
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75294}
    6288483b
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...