• Daniel Clark's avatar
    Move potentially reentrant allocation out of the middle of Module::Reset · 61e2b67e
    Daniel Clark authored
    During Module::Reset(), the module is in an unstable state between the
    change to SourceTextModule::code and Module::status.  Any reentrancy
    between these points is problematic because the normal invariants about
    the value of SourceTextModule::code in relation to Module::status do not
    hold.
    
    An allocation of the exports hash table in the middle of Module::Reset()
    was causing reentrancy during this problematic time.  This change fixes
    the issue by moving the allocation earlier in Reset() before any fields
    are modified.
    
    Bug: v8:9522
    Change-Id: Ia941af60a0b31f05a6d8da610b9a270e7f79dac2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1712449Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#62902}
    61e2b67e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...