• Daniel Clark's avatar
    Move potentially reentrant allocation out of the middle of Module::Reset · 61e2b67e
    Daniel Clark authored
    During Module::Reset(), the module is in an unstable state between the
    change to SourceTextModule::code and Module::status.  Any reentrancy
    between these points is problematic because the normal invariants about
    the value of SourceTextModule::code in relation to Module::status do not
    hold.
    
    An allocation of the exports hash table in the middle of Module::Reset()
    was causing reentrancy during this problematic time.  This change fixes
    the issue by moving the allocation earlier in Reset() before any fields
    are modified.
    
    Bug: v8:9522
    Change-Id: Ia941af60a0b31f05a6d8da610b9a270e7f79dac2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1712449Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#62902}
    61e2b67e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...