• Tobias Tebbi's avatar
    [builtins] add Torque fast-path for String.prototype.localeCompare · 6181ce59
    Tobias Tebbi authored
    This fast path works for ASCII-only strings and is similar to the
    existing fast-path in C++. Important differences:
    - The locale check is done at Turbofan optimization time instead of
      at runtime
    - Use tables of size 256 instead of 128 to save a bounds-check when
      handling one-byte strings.
    - It first performs an equality check that's optimized for detecting
      inequality quickly by comparing the strings from both ends. If the
      equality check succeeds, we are done. Otherwise chances are high
      that the strings differ according to collation level L1 already.
      Therefore, we first do an L1 check and perform the L3 check
      only when L1 didn't find a difference. This is based on the assumption
      that few strings are identical except for different capitalization.
    - Use the Torque version of string flattening instead of the runtime
      version.
    
    Bug: v8:12196
    Change-Id: I2d043c1138846783f6d567b736d34063ba9301e5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268465Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77946}
    6181ce59
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...