• Seth Brenith's avatar
    [torque] Generate accessors for struct-typed class fields · 6160a767
    Seth Brenith authored
    Torque generates runtime accessor member functions for most class fields
    that are defined in .tq files, but fields with struct types are
    currently omitted. This change adds those accessors. As an example, if a
    .tq file defines the following:
    
      struct InternalClassStructElement {
        a: Smi;
        b: Smi;
      }
    
      class InternalClassWithStructElements extends HeapObject {
        const count: Smi;
        entries[count]: InternalClassStructElement;
      }
    
    Then the following accessors are generated to get and set each struct
    field within the 'entries' field:
    
      inline int entries_a(int i) const;
      inline void set_entries_a(int i, int value);
    
      inline int entries_b(int i) const;
      inline void set_entries_b(int i, int value);
    
    Bug: v8:7793
    Change-Id: Ia40b5918e9d09f53ad8e78bc33f8629b8d6a79fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2676926Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#72662}
    6160a767
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...