• Ng Zhi An's avatar
    Reland "[arm] Change fp_fixed registers to be allocatable registers" · 610f72a5
    Ng Zhi An authored
    This relands commit 1a38573f.
    
    The original change used a sequence of instruction in the test that
    could not be scalar lowered properly.
    
    Original change's description:
    > [arm] Change fp_fixed registers to be allocatable registers
    >
    > fp_fixed1 and fp_fixed2 are used by the S8x16Shuffle operation. They
    > need to be allocatable, so that they can be correctly marked as fixed
    > and spilled as required. The previous value of fp_fixed2, d29, is not in
    > the list of allocatable double registers, and not marked as fixed
    > appropriately.
    >
    > One fix could be to extend the list of allocatable double registers, but
    > there is a comment there saying that the list is kept even-length to
    > make stack alignment easier. So rather than messing with that, we
    > instead change what fp_fixed1 and fp_fixed2 is, since S8x16Shuffle is
    > the only user, this is a simpler change.
    >
    > Bug: chromium:1070078
    > Change-Id: Id7de9b256bad2cfb11b0f06b66eb80a48ff7827c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161565
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67372}
    
    Bug: chromium:1070078
    Change-Id: I02bb4b3ad03817318cbd0ee706c5ef4f20c845ba
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165867Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67406}
    610f72a5
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...