• Leszek Swirski's avatar
    [ast] Allocate cons strings in young space on main thread · 60f108f9
    Leszek Swirski authored
    In the case of function names, we allocate ConsStrings only to flatten
    them during finalization. Allocating these ConsStrings in old space
    appears to have regressed some benchmarks (especially memory benchmarks),
    but is necessary for off-thread allocation which doesn't have a young
    space.
    
    Ideally, we would avoid allocating these ConsStrings in the first place,
    and would flatten the data directly from the AstConsString. For now, we
    make them allocate in old space for off-thread allocation only, to
    revert the regressions. In the future we can investigate smarter
    flattening.
    
    Bug: chromium:1011762
    Bug: chromium:1044477, chromium:1044147, chromium:1043573, chromium:1043168
    Change-Id: If24b738d6f2eeb8c0fea042a711deb2a19015fbd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020948
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66025}
    60f108f9
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...