• Dominik Inführ's avatar
    Use list of invalidated objects for old-to-new refs · 60843b42
    Dominik Inführ authored
    Instead of inserting "deletion" entries into the store buffer, keep a
    list of invalidated objects to filter out invalid old-to-new slots.
    
    The first CL https://crrev.com/c/1704109 got reverted because both the
    sweeper and the main task were modifying the invalidated slots data
    structure concurrently. This CL changes this, such that the sweeper
    only modifies the invalidated slots during the final atomic pause when
    the main thread is not running. The sweeper does not need to clean this
    data structure after the pause, since the "update pointers" phase
    already removed all invalidated slots.
    
    The second CL https://crrev.com/c/1733081 got reverted because the
    sweeper might find more free space than the full GC before it. If an
    object shrinks after the pause but before the sweep, the invalidated
    object might span free memory and potentially new allocated objects.
    Therefore shrink invalidated objects when processing swept pages on
    the main thread. Also clean recorded slots in the gap.
    
    TBR=petermarshall@chromium.org
    
    Bug: v8:9454
    Change-Id: I80d1fa3bbc24e97f7c97a373aaad66f105456f12
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751795
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63239}
    60843b42
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...