• Benedikt Meurer's avatar
    [debug][wasm] Move DebugEvaluate implementation to wasm-debug.cc. · 5fc4649d
    Benedikt Meurer authored
    Previously the proxies that make up the DebugEvaluate implementation for
    Wasm frames lived in wasm-js.cc, but that was quite confusing since
    
    (a) the rest of the debug support for Wasm lives in wasm-debug.cc (and
        we intend to eventually unify the DebugEvaluate and Scope objects),
        and
    (b) the wasm-js.cc file is explicitly about the WebAssembly JS API
        that's part of the WebAssembly specification, and the DebugEvaluate
        proxies aren't part of that.
    
    Bug: chromium:1162229, chromium:1071432, chromium:1127914
    Change-Id: I63016dcace6d8e2af4a03c8eed4f02d464c1dee1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609418
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71911}
    5fc4649d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...