• Tobias Tebbi's avatar
    Revert "Reland^2 "[build] disable C++ optimization for mksnapshot code."" · 5f58a82b
    Tobias Tebbi authored
    This reverts commit 6beea97e.
    
    Reason for revert: https://crbug.com/942497
    
    Original change's description:
    > Reland^2 "[build] disable C++ optimization for mksnapshot code."
    >
    > This is a reland of a6b95a6a
    >
    > In addition to UBSan, also ASAN needs optimizations.
    > So this CL doesn't disable optimizations for all sanitizer builds.
    >
    > Original change's description:
    > > Reland "[build] disable C++ optimization for mksnapshot code."
    > >
    > > This is a reland of cee2f772
    > >
    > > Original change's description:
    > > > [build] disable C++ optimization for mksnapshot code.
    > > >
    > > > By disabling C++ optimizations for code that's only run in mksnapshot,
    > > > that is, CSA and Torque-generated code, we can save compile time.
    > > > I observed up to 2x improvements of compile time for some files,
    > > > while the mksnapshot time did not increase significantly.
    > > >
    > > > Bug: v8:7629
    > > > Change-Id: I96be2966611b2471b68023e0dd9e351d94f0013c
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/1460941
    > > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#59585}
    > >
    > > Bug: v8:7629
    > > Change-Id: I8330f93173ab3d7b400e15ea4935bbe8256b250f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1473292
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#59606}
    >
    > Bug: v8:7629
    > Change-Id: I42175c472d8e41345573df81645dfe3accc9d8c4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1475396
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59632}
    
    TBR=yangguo@chromium.org,sigurds@chromium.org,tebbi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:7629 chromium:942497
    Change-Id: Ie51d7b53440230b41fb763541908cb1162d8850d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549158
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60577}
    5f58a82b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...