• Zhi An Ng's avatar
    [wasm-simd][x64] Fix definition of Shufps · 5f4b0e47
    Zhi An Ng authored
    The definition of Shufps is wrong, we are incorrectly passing 0 as the
    immediate in all cases. No tests broke because we only used Shufps for
    splats, which has imm8 == 0 anyway.
    
    Also, it was using movss, which only moves a single 32-bit. Because we
    were using it only for f32x4 splat, this ended up being enough (imm8 ==
    0 meant that we only shuffled the low 32-bit). This is fixed to use
    movaps, which moves the entire 128-bit register.
    
    Also tweak the definition of Shufps to take 4 arguments. `vshufps dst,
    src1, src2, imm8` shuffles src1 and src2 into dst. `shufps dst, src,
    imm8`, shuffles dst and src into dst.
    
    So `Shufps(dst, src, imm8)` is ambiguous in the AVX case, it could be:
    1. vshufps(dst, src, src, imm8), or
    2. vshufps(dst, dst, src, imm8)
    
    2. is more likely to be the intended behavior, but it introduces a false
    dependency on the value of dst.
    
    With `Shufps(dst, src1, src2, imm8)`, it is clearer what the behavior
    should be:
    1. shufps(dst, src2, imm8) matches the AVX behavior IFF dst == src1.
    
    Change-Id: I60dc4ec868023d28d00f2b09d2c53b82a729bc4d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2591849Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71775}
    5f4b0e47
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...