• Andreas Haas's avatar
    [wasm] During instantiation, pending_exceptions dominate new exceptions · 5f105141
    Andreas Haas authored
    For async instantiation of WebAssembly code we had the assumption that
    a pending exceptions (an exception which comes from
    execution JS code) and an ErrorThrower error cannot occur at the same
    time. This assumption turned out to be wrong. With this CL we handle
    this case by prefering pending_exceptions over ErrorThrower errors.
    
    In addition I extended the tests for failing instantiation to also
    exercise async instantiation, and I added a regression test.
    
    R=clemensh@chromium.org
    
    Bug: chromium:870646
    Change-Id: I4cb54ff8642ad4ea193b20f79905c9f6508c2b2e
    Reviewed-on: https://chromium-review.googlesource.com/1163511Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54940}
    5f105141
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...