• Dan Elphick's avatar
    [ubsan] Make Isolate inherit from Factory · 5ed349d6
    Dan Elphick authored
    Previously Isolate and Factory relied on the undefined behavior of
    reinterpret_cast to switch between the two unrelated classes (which worked
    because Factory had no data members).
    
    With Isolate inheriting from Factory, it's now possible to switch between the
    two classes using c-style casts. These are allowed under the C++ standard.
    
    The inheritance is private which allows the continuing separation of the
    Factory and Isolate namespaces.
    
    This is a defensive clean-up, since ubsan does not yet detect the previous
    undefined behavior.
    
    Bug: v8:3770
    Change-Id: I0ccf09f1d34f747550812ce698ab7e182812409e
    Reviewed-on: https://chromium-review.googlesource.com/1010122Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52615}
    5ed349d6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...