• Eric Holk (eholk)'s avatar
    Reland "[wasm] always allocate memory when guard regions are needed" · 5e76ff5a
    Eric Holk (eholk) authored
    This reverts commit 7cf29d8d.
    
    Original change's description:
    > [wasm] always allocate memory when guard regions are needed
    >
    > When using trap handlers, memory references do not get any checks inserted. This
    > means there is no check for a null memory as happens when the memory size is
    > 0. Normally this would be correctly caught as an out of bounds access, since the
    > low memory addresses are not normally mapped. However, if they were mapped for
    > some reason, we would not catch the out of bounds access.
    >
    > The fix is to ensure WebAssembly instances always have a guard region even if
    > the memory is size 0.
    >
    > Bug: chromium:769637
    
    Change-Id: I09fdaea92b7ccb3a6cc9e28392171ec098538a00
    Reviewed-on: https://chromium-review.googlesource.com/695812
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48293}
    5e76ff5a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...