• Igor Sheludko's avatar
    [csa] Fix semantics of PopAndReturn · 5e5eaf79
    Igor Sheludko authored
    This CL prohibits using PopAndReturn from the builtins that
    have calling convention with arguments on the stack.
    
    This CL also updates the PopAndReturn tests so that even off-by-one
    errors in the number of poped arguments are caught which was not the
    case before.
    
    Motivation:
    
    PopAndReturn is supposed to be using ONLY in CSA/Torque builtins for
    dropping ALL JS arguments that are currently located on the stack.
    Disallowing PopAndReturn in builtins with stack arguments simplifies
    semantics of this instruction because in case of presence of declared
    stack parameters it's impossible to distinguish the following cases:
    1) stack parameter is included in JS arguments (and therefore it will
       be dropped as a part of 'pop' number of arguments),
    2) stack parameter is NOT included in JS arguments (and therefore it
       should be dropped in ADDITION to the 'pop' number of arguments).
    
    This issue wasn't noticed before because builtins with stack parameters
    relied on adapter frames machinery to ensure that the expected
    parameters are present on the stack, but on the same time the adapter
    frame tearing down code was effectively recovering the stack pointer
    potentially broken by the CSA builtin.
    
    Once we get rid of the arguments adapter frames keeping stack pointer
    in a valid state becomes crucial.
    
    Bug: v8:5269, v8:10201
    Change-Id: Id3ea9730bb0d41d17999c73136c4dfada374a822
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460819
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70454}
    5e5eaf79
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...