• Manos Koukoutos's avatar
    [wasm] Properly implement parsing of s33 values · 5df74c35
    Manos Koukoutos authored
    Motivation:
    We used to approximate s33/i33 value parsing by first checking for
    specific negative codes, and then parsing an u32 value if that failed.
    This is not correct in all cases.
    
    Changes:
    - Implement i33 parsing in Decoder.
    - Factor out parsing of heap types into read_heap_type.
    - Introduce HeapType::kBottom.
    - Introduce helper functions in WasmFeatures and value_type_reader.
    - Remove macros from the parsing of value types.
    - HeapType::code now returns an i32 for compatibility with the i33
      requirement.
    - Introduce HeapType::Repr.
    - Renamings: HeapType::type() -> representation(),
                 ValueType::heap() -> heap_representation()
    
    Bug: v8:7748
    Change-Id: I04deabce8837a48af2226411cd706a397f9e5725
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274118
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68633}
    5df74c35
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...