• Clemens Backes's avatar
    [wasm] Disallow nullptr modules in decoder · 6b633af7
    Clemens Backes authored
    In production, we will always pass a pointer to the decoded module. The
    only reason for the existance of the nullptr checks is that tests
    sometimes don't pass a module here. Hence we pay in production code for
    a test-only feature.
    
    This CL fixes this by always passing a module pointer from the decoder
    tests. This even simplifies the code a lot by removing redundant code.
    
    The {TestModuleBuilder} class was moved before the definitions of the
    {FunctionBodyDecoderTest} class in order to be able to reuse it there.
    It's unmodified otherwise.
    
    R=ahaas@chromium.org
    
    Bug: v8:10576
    Change-Id: I7d876bfc8a27b50fe713afb8848fb4f642287cfa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226749Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68116}
    6b633af7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...