• Benedikt Meurer's avatar
    [turbofan] Don't leak "the hole" into the callback function. · 5bd74f31
    Benedikt Meurer authored
    The contract in TurboFan is that "the hole" is never passed to "user
    JavaScript", which we unfortunately still don't check strictly. Now
    the inlined code for Array#forEach properly checks for "the hole",
    but the type of the element Node passed to the callback function
    doesn't reflect that. So introduce a proper TypeGuard here to reflect
    this check.
    
    This will also improve code generation for iteration of HOLEY arrays
    better and might improve performance a bit.
    
    Bug: v8:1956
    Change-Id: Ib6b3c444b16fcf44551bda1b39f976d66b9362ab
    Reviewed-on: https://chromium-review.googlesource.com/705954Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48400}
    5bd74f31
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...