• Ulan Degenbaev's avatar
    [heap] Make assert in Page::ShrinkToHighWaterMark more robust. · 5bc1d291
    Ulan Degenbaev authored
    Currently Page::ShrinkToHighWaterMark checks that there is only one
    filler in the to-be-freed area at the end of the page. This does not
    hold if an allocation observer is active.
    
    We should instead check that the to-be-freed area does not contain
    allocated objects and will not contain allocated objects:
    1) Following chain of fillers we arrive at the end of the page.
    2) The free list of the page is empty.
    
    This patch also changes PagedSpace::ResetFreeList to evict free list
    entries of each page, instead of just reseting the global free list.
    
    It also removes invalidation of free list categories.
    Now FreeList::EvictFreeListItems simply evicts free list entries without
    invalidating free list categories.
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I6051578ec2c91c9614d14c7a6ce188d2db5ace3b
    Reviewed-on: https://chromium-review.googlesource.com/822571
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50040}
    5bc1d291
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...