• Tobias Tebbi's avatar
    [elements] handle OOB-holes in Array.prototype.includes fast-path · 5b92f91c
    Tobias Tebbi authored
    In the ElementsAccessor fast-path for Array.prototype.includes, we
    iterate backing-store elements according to start and length numbers
    which might or might not be within the JSArray::length field, for
    example when side-effects changed the receiver while start and length
    are computed. So even when we have a packed ElementsKind, we might still
    observe the hole. This is fine, since logical out-of-bounds accesses
    are safe in this case, but it means we must not rely on the
    ElementsKind telling us if we can encounter holes.
    
    Bug: chromium:897098
    Change-Id: I17db38246aef6edbdd5cee30598cbf7619aba6d8
    Reviewed-on: https://chromium-review.googlesource.com/c/1293571Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56884}
    5b92f91c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...