• Marja Hölttä's avatar
    [IC] Clarify receiver vs holder vs lookup start object · 5a6ff768
    Marja Hölttä authored
    LoadICParameters already has separate fields for receiver and holder,
    though, in practice, they were always equal. Moreover, the holder didn't
    mean holder, but the lookup start object.
    
    This CL makes parts of the IC layer reusable for cases where they are
    not equal, by clarifying whether we're accessing the receiver, the
    lookup_start_object, or the holder.
    
    List of changes:
    
    StoreICParameters:
    - Detached from LoadICParameters, now they are independent classes.
    
    LoadICParameters:
    - Renamed holder to lookup_start_object.
    
    TryProbeStubCache:
    - Renamed receiver to lookup_start_object.
    
    LoadIC:
    LoadIC_BytecodeHandler:
    LoadIC_NoFeedback:
    KeyedLoadIC:
    KeyedLoadICGeneric:
    KeyedLoadICPolymorphicName:
    - These won't be reused in the receiver != lookup_start_object case,
    so added asserts that receiver == lookup_start_object.
    
    TryMonomorphicCase:
    HandlePolymorphicCase:
    LoadIC_Noninlined:
    GenericElementLoad:
    - Renamed receiver_map param to lookup_start_object_map. The callers
    either assert receiver == lookup_start_object, or read the map from the
    lookup start object.
    
    GenericPropertyLoad:
    - Renamed receiver param to lookup_start_object.
    - Renamed receiver_map param to lookup_start_object_map. The callers
    either assert receiver == lookup_start_object, or read the map from the
    lookup start object.
    
    CallGetterIfAccessor:
    - Added the holder parameter and used it accordingly.
    
    
    Bug: v8:9237
    Change-Id: I27aca08f58bd66cc9bd1b1baf9f1ff5565d795eb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362918
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69606}
    5a6ff768
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...