• Marja Hölttä's avatar
    [IC] Clarify receiver vs holder vs lookup start object · 5a6ff768
    Marja Hölttä authored
    LoadICParameters already has separate fields for receiver and holder,
    though, in practice, they were always equal. Moreover, the holder didn't
    mean holder, but the lookup start object.
    
    This CL makes parts of the IC layer reusable for cases where they are
    not equal, by clarifying whether we're accessing the receiver, the
    lookup_start_object, or the holder.
    
    List of changes:
    
    StoreICParameters:
    - Detached from LoadICParameters, now they are independent classes.
    
    LoadICParameters:
    - Renamed holder to lookup_start_object.
    
    TryProbeStubCache:
    - Renamed receiver to lookup_start_object.
    
    LoadIC:
    LoadIC_BytecodeHandler:
    LoadIC_NoFeedback:
    KeyedLoadIC:
    KeyedLoadICGeneric:
    KeyedLoadICPolymorphicName:
    - These won't be reused in the receiver != lookup_start_object case,
    so added asserts that receiver == lookup_start_object.
    
    TryMonomorphicCase:
    HandlePolymorphicCase:
    LoadIC_Noninlined:
    GenericElementLoad:
    - Renamed receiver_map param to lookup_start_object_map. The callers
    either assert receiver == lookup_start_object, or read the map from the
    lookup start object.
    
    GenericPropertyLoad:
    - Renamed receiver param to lookup_start_object.
    - Renamed receiver_map param to lookup_start_object_map. The callers
    either assert receiver == lookup_start_object, or read the map from the
    lookup start object.
    
    CallGetterIfAccessor:
    - Added the holder parameter and used it accordingly.
    
    
    Bug: v8:9237
    Change-Id: I27aca08f58bd66cc9bd1b1baf9f1ff5565d795eb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362918
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69606}
    5a6ff768
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...