• adamk's avatar
    [parser] Remove hoist_scope from DeclarationDescriptor · 59b8496c
    adamk authored
    The hoist_scope member of DeclarationDescriptor was only used to pass the function
    scope for declaration of parameters containing sloppy evals, for example:
    
      function f(x = eval("var y")) { }
    
    In cases like this, "x" is declared in the function scope but "y" is declared in an inner scope.
    Rather than passing the function scope as "hoist_scope", we simply ask for the outer_scope()
    of the inner scope as needed in PatternRewriter.
    
    This reduces the cognitive overhead of understanding what a DeclarationDescriptor has; for
    example, it removes some dead code from the PreParser which never has to deal
    with a situation like the example above.
    
    Review-Url: https://codereview.chromium.org/2662183002
    Cr-Commit-Position: refs/heads/master@{#42861}
    59b8496c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...