• mstarzinger's avatar
    Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of... · 5977ed02
    mstarzinger authored
    Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of https://codereview.chromium.org/1002203002/)
    
    Reason for revert:
    Layout test failure in inspector/sources/debugger/debugger-pause-on-promise-rejection.html
    
    Original issue's description:
    > Remove kind field from StackHandler.
    >
    > This makes the Isolate::Throw logic not depend on a prediction of
    > whether an exception is caught or uncaught. Such a prediction is
    > inherently undecidable because a finally block can decide between
    > consuming or re-throwing an exception depending on arbitray control
    > flow.
    >
    > There still is a conservative prediction mechanism in place that
    > components like the debugger or tracing can use for reporting.
    >
    > With this change we can get rid of the StackHandler::kind field, a
    > pre-requisite to do table-based lookups of exception handlers.
    >
    > R=yangguo@chromium.org
    >
    > Committed: https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff
    > Cr-Commit-Position: refs/heads/master@{#27210}
    
    TBR=yangguo@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review URL: https://codereview.chromium.org/1009903002
    
    Cr-Commit-Position: refs/heads/master@{#27215}
    5977ed02
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...