• brucedawson's avatar
    Enforce strict weak ordering on NaN frequencies · 58ba4cef
    brucedawson authored
    In crrev.com/2856103002 sentinel frequency values were introduced, using
    NaN as the sentinel. However the comparison function was not *fully*
    updated to support these - comparing two NaNs would give ambiguous
    results. This caused test failures when building with VS 2017, probably
    because of subtle changes in the arrangement of nodes in the tree.
    
    This change uses the the node ID to break ties. An alternative would be
    to use a non-NaN sentinel value.
    
    R=bmeurer@chromium.org
    BUG=chromium:722480
    
    Review-Url: https://codereview.chromium.org/2894433004
    Cr-Commit-Position: refs/heads/master@{#45415}
    58ba4cef
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
DEPS.chromium Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...