• Tobias Tebbi's avatar
    [profiler] fix 4 bugs in --prof/linux-tick-processor · 58b45cca
    Tobias Tebbi authored
    - In log.cc, we used InstructionStart() for code create events, but
      the Code object address for code move events. Change to use
      InstructionStart() for both.
    - The symbol table contains some kind of virtual address, not file
      offsets. They happened to be identical in the past but are no longer,
      probably due to toolchain changes. Now we use objdump to figure out
      the difference between virtual addresses and file offsets.
    - When a new code object happened to be created at the same address as
      a previous one, we wouldn't update it.
      This is indeed wrong, as predicted in a TODO by Jaro.
    - For 64bit addresses, using >>> is wrong, now replaced with division.
    
    
    Change-Id: Ib23114ed736f98bfc33c65004a039a3fd04d3c49
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016586Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66145}
    58b45cca
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...