• vogelheim's avatar
    Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput) · 57f0a521
    vogelheim authored
    PushBack(end-of-input) is a little weird, but since
    Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
    when at the end of the stream, pushing back the end-of-input token needs
    to do the exact inverse.
    
    (The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is often dereferenced
     directly to access memory and so always needs to point to, well, memory.)
    (The PushBack implementation for all other streams looks correct.)
    
    R=rossberg@chromium.org
    BUG=chromium:607903
    LOG=Y
    
    Review-Url: https://codereview.chromium.org/1941843002
    Cr-Commit-Position: refs/heads/master@{#35968}
    57f0a521
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...