• hans's avatar
    Remove unnecessary friend decls; fix Win-Clang builds · 57ca0f36
    hans authored
    Clang builds on Windows were failing with:
    
    ..\..\v8\src\register-configuration.cc(85,17) :  error: unqualified friend
    declaration referring to type outside of the nearest enclosing namespace is
    a Microsoft extension; add a nested name specifier
    [-Werror,-Wmicrosoft-unqualified-friend]
    
      friend struct Register;
                    ^
                    ::v8::internal::
    
    How did it work on non-Windows? The friend declarations were declaring
    new Register and DoubleRegister structs in the current namespace, instead
    of refering the existing classes in the outer namespce.
    
    The code isn't referencing any private members of these classes anyway,
    so let's drop the friend declarations.
    
    BUG=82385
    LOG=n
    
    Review URL: https://codereview.chromium.org/1389723002
    
    Cr-Commit-Position: refs/heads/master@{#31113}
    57ca0f36
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...