• Ng Zhi An's avatar
    [wasm-simd][arm] Use vmov to move all ones to register · 57242a05
    Ng Zhi An authored
    vceq(dst, dst, dst) does not seem to always set the register to all
    ones. The right way should be be to use vmov (immediate) anyway. This
    was not supported in the assembler yet, so we need changes to the
    assembler, diassembler, and simulator.
    
    There is an unfortunate fork in logic in the simulator, due to the way
    the switches are set up, vmov (imm) logic is duplicated across two
    different cases, because the switch looks at the top bit of the
    immediate. Refactoring this will be a bigger change that is irrelevant
    for this bug, so I'm putting that off for now. Instead we extract the
    core of vmov (imm) into helpers and call it in the two cases.
    
    Bug: chromium:1112124
    Change-Id: I283dbcd86cb0572e5ee720835f897b51fae96701
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2337503
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69315}
    57242a05
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-wrapper-inl.h Loading commit data...
local-isolate-wrapper.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
off-thread-isolate-inl.h Loading commit data...
off-thread-isolate.cc Loading commit data...
off-thread-isolate.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...