• Anna Henningsen's avatar
    [wasm] avoid handle leak in AsyncCompileJob::CompileTask · 5719ca6e
    Anna Henningsen authored
    The `SaveContext` operation in `AsyncCompileJob::CompileTask` allocates
    a handle. However, the platform implementation may not be able
    to provide a `HandleScope`, since it cannot tell whether the isolate
    is disposed (and the task canceled) at the time it runs the task;
    so it is an API requirement of `CancelableTask` is that `RunInternal()`
    does not leak any handles into outside scopes.
    
    Change-Id: I86db36ddc71f774a31d5bc13b7399ef961374d6f
    Reviewed-on: https://chromium-review.googlesource.com/668397Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48042}
    5719ca6e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...