• Leszek Swirski's avatar
    [runtime] Fix sandboxing violation in CopyDataPropertiesWithExclProp · d05a38f9
    Leszek Swirski authored
    The newly optimised CopyDataPropertiesWithExcludedProperties acceses the
    excluded properties directly on the stack, to avoid pushing them twice.
    This meant that we had to pass a stack pointer into the runtime, which
    we couldn't do directly because all arguments to runtime functions
    should be tagged.
    
    We tried to work around this by passing the stack pointer in a Foreign,
    but this violated the V8 sandbox. Fortunately, the stack pointer is
    aligned, so it looks like a Smi to the GC. So, we can pass it directly
    on the stack as a runtime argument but doing a bit of bitcasting.
    
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng
    Bug: v8:11614
    Change-Id: I87c4a34a15ae863277142aa29f48b1dd546014e0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497745
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79369}
    d05a38f9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...