• Benedikt Meurer's avatar
    [inspector] Add custom error dispatch machinery for debug evaluate. · 56cfdd68
    Benedikt Meurer authored
    This introduces a `V8InspectorClient::dispatchError()` callback that
    embedders can use to dispatch errors from scripts injected by DevTools
    (via debug evaluate). The idea here being that while these errors are
    technically caught by the inspector logic, the DevTools UX presents them
    just like other uncaught errors, with the exception that they don't
    trigger error handlers installed by the page. The latter can be quite
    confusing to developers, and surprising when for example testing these
    error handlers from DevTools. So this adds the foundations on the V8
    side to enable triggering error handlers for these technically caught,
    but morally uncaught, exceptions.
    
    On the Chromium side https://crrev.com/c/3560458 will implement and
    use the hook. And that CL also adds a web tests to check the behavior.
    
    Bug: chromium:1295750
    Change-Id: I945c8a9e9b4ec5705fc7f1891dcda185b04c8310
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557234
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79673}
    56cfdd68
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...