• yangguo's avatar
    Revert of [debugger] reapply break points after clearing one shots. (patchset... · 56b7a5fa
    yangguo authored
    Revert of [debugger] reapply break points after clearing one shots. (patchset #1 id:1 of https://codereview.chromium.org/2221333002/ )
    
    Reason for revert:
    Found better solution.
    
    Original issue's description:
    > [debugger] reapply break points after clearing one shots.
    >
    > On the debug info, we have a list of existing break points.  When we
    > step in the debugger, we flood the function with one-shot break points.
    > Afterwards, we clear these one-shots by clearing all break locations.
    >
    > Previously, while clearing break locations, we would skip ones that have
    > actual break points. Now we clear all break locations, and then reapply
    > break points. This is necessary for the next step, when we encode break
    > point info by source position, and not code offset. Encoding by code
    > offset would mean that break points are dependent on the code kind we
    > use.
    >
    > R=jgruber@chromium.org
    > BUG=v8:5265
    >
    > Committed: https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e
    > Cr-Commit-Position: refs/heads/master@{#38492}
    
    TBR=jgruber@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5265
    
    Review-Url: https://codereview.chromium.org/2231653003
    Cr-Commit-Position: refs/heads/master@{#38521}
    56b7a5fa
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...