• Clemens Backes's avatar
    Revert "[arm64][wasm] Use NEON S/Usra for Wasm SIMD add(shr(x, imm), y)" · 55e6a51f
    Clemens Backes authored
    This reverts commit 2261e053.
    
    Reason for revert: No issues with the CL, but it is taking the
    last two available opcodes on arm64 (we use 9 bits to encode it,
    so we are limited to 512 opcodes). We need to land a security fix
    which includes the addition of two opcodes. Before relanding this,
    we need to figure out a strategy to either reduce opcodes, or use
    one more bit to encode them.
    
    Original change's description:
    > [arm64][wasm] Use NEON S/Usra for Wasm SIMD add(shr(x, imm), y)
    >
    > A single AArch64 SIMD signed/unsigned Shift Right and Accumulate can be
    > used to implement Wasm SIMD add(shr(x, imm), y). This gives a 1-1.5%
    > improvement on some compute intensive Wasm benchmarks on Neoverse-N1.
    >
    > Mla and Adalp optimisations were refactored to match the style of the
    > added code.
    >
    > Change-Id: Id5959a31ca267e02b7d60e7ff6f942adb029b41e
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089157
    > Reviewed-by: Zhi An Ng <zhin@chromium.org>
    > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
    > Cr-Commit-Position: refs/heads/master@{#76280}
    
    Change-Id: Ifad0625ed8a6b66e7a7a74da11ad7d60941207e5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094014
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#76282}
    55e6a51f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...