• chunyang.dai's avatar
    X87: [builtins] Unify the String constructor. · 55da29f4
    chunyang.dai authored
    port a3d6f6cc (r30759).
    
    original commit message:
    
        Implement the String constructor completely as native builtin,
        avoiding the need to do gymnastics in JavaScript builtin to
        properly detect the no argument case (which is different from
        the undefined argument case) and also allowing to just
        tailcall through to ToString or SymbolDescriptiveString for
        the common case. Also the JavaScript builtin was misleading
        since the case for construct call was unused, but could be
        triggered in a wrong way once we support tail calls from
        constructor functions.
    
        This refactoring allows us to properly implement subclassing
        for String builtins, once we have the correct initial_map on
        derived classes (it's merely a matter of using NewTarget
        instead of the target register now).
    
        This introduces a new %SymbolDescriptiveString runtime
        entry, which is also used by Symbol.toString() now.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1349403002
    
    Cr-Commit-Position: refs/heads/master@{#30826}
    55da29f4
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...