• jgruber's avatar
    [string] Fix regexp fast path in MaybeCallFunctionAtSymbol · 55a98076
    jgruber authored
    The regexp fast path in MaybeCallFunctionAtSymbol had an issue in which
    we'd call ToString after checking that the given {object} was a fast
    regexp and deciding to take the fast path. This is invalid since
    ToString() can call into user-controlled JS and may mutate {object}.
    
    There's no way to place the ToString call correctly in this instance:
    1 before BranchIfFastRegExp, it's a spec violation if we end up on the
      slow regexp path;
    2 the problem with the current location is already described above;
    3 and we can't place it into the fast-path regexp builtin (e.g.
      RegExpReplace) either due to the same reasons as 1.
    
    The solution in this CL is to restrict the fast path to string
    arguments only, i.e. cases where ToString would be a nop and can safely
    be skipped.
    
    Bug: chromium:782145
    Change-Id: Ifd35b3a9a6cf2e77c96cb860a8ec98eaec35aa85
    Reviewed-on: https://chromium-review.googlesource.com/758257
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49213}
    55a98076
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...